Former-submariner-turned-senator Rex Patrick says a decision to make nuclear-powered submarines in Australia had to happen, but will come at a short-term cost for Adelaide shipbuilders who could face another "valley of death".