The billionaire investor Carl Icahn has been under assault from the short-seller Hindenburg Research, forcing him to renegotiate a key loan deal.